Bring back redundant notifications for GtkToggleButton::draw-indicator
authorMatthias Clasen <mclasen@redhat.com>
Sat, 28 Jun 2014 01:22:40 +0000 (21:22 -0400)
committerMatthias Clasen <mclasen@redhat.com>
Sat, 28 Jun 2014 01:22:40 +0000 (21:22 -0400)
GtkCheckButton sets a different initial value for this property without
actually changing the declared default, and then relies on change notification
to update other properties (such as xalign). This, combined with glades
insistance on putting default values into ui files creates a situation
where we can't remove the redundant notification for ::draw-indicator
without causing lots of checkboxes to suddenly have centered labels.
This was seen in gnome-terminal, evolution, and other applications.

Therefore, keep the extra notification for now. This can be revisited
when we clean up the button hierarchy.

gtk/gtktogglebutton.c

index ef5ece56df588f89833a00494e2763e2f84a761e..c73ab85eb1bd0b8949e3ea5a3ffb03de8caeaff4 100644 (file)
@@ -202,7 +202,7 @@ gtk_toggle_button_class_init (GtkToggleButtonClass *class)
                                                         P_("Draw Indicator"),
                                                         P_("If the toggle part of the button is displayed"),
                                                         FALSE,
-                                                        GTK_PARAM_READWRITE|G_PARAM_EXPLICIT_NOTIFY));
+                                                        GTK_PARAM_READWRITE));
 
   /**
    * GtkToggleButton::toggled: